Add stub definitions of inject debug resources targets to fix runtimeinfo build dependency issues. #51254
Conversation
…info build dependency issues.
|
Tagging subscribers to this area: @hoyosjs |
|
@jkoritzinsky that appears to have fixed the issue for me. Thank you! |
| @@ -243,6 +243,9 @@ if(CLR_CMAKE_TARGET_WIN32) | |||
| add_custom_target(inject_debug_resources_singlefilehost ALL DEPENDS ${CMAKE_CURRENT_BINARY_DIR}/${CMAKE_CFG_INTDIR}/inject_debug_resources_singlefilehost.timestamp) | |||
| add_dependencies(runtime inject_debug_resources_singlefilehost) | |||
| endif() | |||
| else() | |||
| add_custom_target(inject_debug_resources_coreclr DEPENDS coreclr) | |||
There was a problem hiding this comment.
The other thing that we could do is make runtimeinfo depend on inject_debug_resources_coreclr on windows, given that conceptually there's no external resources needed for debugging coreclr. Do you have a preference between the dependencies vs this phony target?
There was a problem hiding this comment.
I'd rather do the phony target so we don't need to add a different dependency that has the same effect on non-Windows platforms.
|
Hello @hoyosjs! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
Failure looks like a machine disconnect. Merging. |
ghost
locked as resolved and limited conversation to collaborators
Should fix #51248
@vcsjones can you validate?